Code review comment for ~jawn-smith/ubuntu/+source/u-boot:ubuntu/focal-devel

Revision history for this message
Dave Jones (waveform) wrote :

Looks basically fine (ignoring the massive diff and just concentrating on the changes in the debian/ dir compared to other SRUs and hirsute itself). Just two minor modifications I'd like to make before uploading this: I'm going to require opensbi >= 0.8-1~ (which is the version in which fw_dynamic.bin was added, which is required for building the risc-v u-boot binary), and to cut-out the post-focal entries in d/changelog.

Otherwise, very nice!

review: Approve

« Back to merge proposal