Software Updater

Merge lp://qastaging/~jawn-smith/update-manager/hwe-kernel-scope into lp://qastaging/update-manager

hwe-kernel-scope
Merge into main

Proposed by William Wilson on 2021-01-05

Status:

Merged

Merged at revision:

2902

Proposed branch:

lp://qastaging/~jawn-smith/update-manager/hwe-kernel-scope

Merge into:

lp://qastaging/update-manager

Diff against target:

237 lines (+105/-43)

6 files modified

UpdateManager/Core/UpdateList.py (+22/-38)
UpdateManager/Dialogs.py (+3/-2)
debian/changelog (+6/-1)
tests/aptroot-grouping-test/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid_main_binary-amd64_Packages (+24/-0)
tests/aptroot-grouping-test/var/lib/dpkg/status (+30/-0)
tests/test_update_list.py (+20/-2)

To merge this branch:

bzr merge lp://qastaging/~jawn-smith/update-manager/hwe-kernel-scope

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Brian Murray		2021-01-05	Needs Fixing on 2021-01-07
Review via email: mp+395808@code.qastaging.launchpad.net

Description of the change

Added the hwe kernel packages to the get_linux_packages function that groups them under Ubuntu Base

lp://qastaging/~jawn-smith/update-manager/hwe-kernel-scope updated on 2021-01-07

2903. By William Wilson on 2021-01-07: Moving to using the kernel regex check in 01autoremove rather than a static list for packages that need to appear under Ubuntu Base

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-01-07:

This looks good, thanks for working on this. I think it'd be best to test a couple more regular expressions that appear in 01autoremove though as it may actually group more packages under "Ubunt u Base" than we want.

review: Needs Information

lp://qastaging/~jawn-smith/update-manager/hwe-kernel-scope updated on 2021-01-07

2904. By William Wilson on 2021-01-07: refining regex used to determine Ubuntu Base packages
2905. By William Wilson on 2021-01-07: Adding new test to ensure certain packages are not grouped under Ubuntu Base. Also small regex update

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-01-07:

This looks really good, I've just made a couple of minor comments which appear in-line.

review: Needs Fixing

lp://qastaging/~jawn-smith/update-manager/hwe-kernel-scope updated on 2021-01-08

2906. By William Wilson on 2021-01-08: LP: #1902025 clarifying meta vs linux packages, fixing changelog, using tuple instead of list for immutability