Merge lp://qastaging/~jaytaoko/unity/unity-event-architecture-final into lp://qastaging/unity

Proposed by Jay Taoko
Status: Merged
Merged at revision: 1286
Proposed branch: lp://qastaging/~jaytaoko/unity/unity-event-architecture-final
Merge into: lp://qastaging/unity
Diff against target: 1381 lines (+360/-89)
54 files modified
plugins/unityshell/src/DebugDBusInterface.cpp (+2/-2)
plugins/unityshell/src/DebugDBusInterface.h (+1/-1)
plugins/unityshell/src/IconTexture.cpp (+18/-0)
plugins/unityshell/src/IconTexture.h (+7/-1)
plugins/unityshell/src/Introspectable.cpp (+3/-0)
plugins/unityshell/src/Introspectable.h (+3/-1)
plugins/unityshell/src/Launcher.cpp (+16/-1)
plugins/unityshell/src/Launcher.h (+9/-1)
plugins/unityshell/src/LauncherIcon.cpp (+3/-3)
plugins/unityshell/src/LauncherIcon.h (+2/-1)
plugins/unityshell/src/PanelController.h (+1/-1)
plugins/unityshell/src/PanelHomeButton.h (+1/-1)
plugins/unityshell/src/PanelIndicatorObjectEntryView.h (+1/-1)
plugins/unityshell/src/PanelIndicatorObjectView.h (+1/-1)
plugins/unityshell/src/PanelMenuView.cpp (+74/-0)
plugins/unityshell/src/PanelMenuView.h (+4/-0)
plugins/unityshell/src/PanelTitlebarGrabAreaView.h (+1/-1)
plugins/unityshell/src/PanelTray.h (+1/-1)
plugins/unityshell/src/PanelView.cpp (+5/-2)
plugins/unityshell/src/PanelView.h (+1/-1)
plugins/unityshell/src/PlacesController.cpp (+2/-0)
plugins/unityshell/src/PlacesController.h (+1/-1)
plugins/unityshell/src/PlacesEmptyView.h (+1/-1)
plugins/unityshell/src/PlacesGroup.cpp (+29/-5)
plugins/unityshell/src/PlacesGroup.h (+4/-0)
plugins/unityshell/src/PlacesGroupController.cpp (+1/-0)
plugins/unityshell/src/PlacesGroupController.h (+1/-1)
plugins/unityshell/src/PlacesHomeView.cpp (+1/-0)
plugins/unityshell/src/PlacesHomeView.h (+1/-1)
plugins/unityshell/src/PlacesHorizontalTile.h (+1/-1)
plugins/unityshell/src/PlacesResultsController.h (+1/-1)
plugins/unityshell/src/PlacesSearchBar.cpp (+10/-1)
plugins/unityshell/src/PlacesSearchBar.h (+4/-1)
plugins/unityshell/src/PlacesSearchBarSpinner.cpp (+9/-0)
plugins/unityshell/src/PlacesSearchBarSpinner.h (+4/-1)
plugins/unityshell/src/PlacesSimpleTile.h (+1/-1)
plugins/unityshell/src/PlacesTile.cpp (+18/-7)
plugins/unityshell/src/PlacesTile.h (+4/-3)
plugins/unityshell/src/PlacesVScrollBar.cpp (+28/-28)
plugins/unityshell/src/PlacesVScrollBar.h (+2/-2)
plugins/unityshell/src/PlacesView.cpp (+20/-0)
plugins/unityshell/src/PlacesView.h (+4/-1)
plugins/unityshell/src/QuicklistManager.cpp (+1/-0)
plugins/unityshell/src/QuicklistMenuItem.h (+1/-1)
plugins/unityshell/src/QuicklistView.cpp (+17/-2)
plugins/unityshell/src/QuicklistView.h (+6/-1)
plugins/unityshell/src/StaticCairoText.cpp (+19/-0)
plugins/unityshell/src/StaticCairoText.h (+6/-0)
plugins/unityshell/src/SwitcherView.h (+1/-1)
plugins/unityshell/src/Tooltip.h (+1/-1)
plugins/unityshell/src/WindowButtons.h (+1/-1)
plugins/unityshell/src/nux-area-accessible.cpp (+3/-3)
plugins/unityshell/src/nux-view-accessible.cpp (+2/-2)
plugins/unityshell/src/unityshell.h (+1/-1)
To merge this branch: bzr merge lp://qastaging/~jaytaoko/unity/unity-event-architecture-final
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Review via email: mp+68255@code.qastaging.launchpad.net

Description of the change

This branch has been adapted to the new event system in Nux.

All the member functions ::ProcessEvent are now obsolete. However you should see that the changes to Unity are not that big.
Here is what to expect with this branch:
   - Keyboard navigation in the dash is functional, minus a few glitches to resolve.
   - Alt+F1 is working in the launcher. Key navigation in and out of the quicklist is also working.

Please report all the regressions you see.

To post a comment you must log in.
Revision history for this message
Marco Biscaro (marcobiscaro2112) wrote :

There is a little conflict in LauncherIcon.cpp

Revision history for this message
Jason Smith (jassmith) wrote :

+1 excellent work

review: Needs Fixing
Revision history for this message
Jason Smith (jassmith) wrote :

+1 meant to say approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.