Checkbox

Merge lp://qastaging/~jbicha/checkbox/update-vcs-link into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging

  1. update-vcs-link
  2. Merge into checkbox-packaging
Proposed by Jeremy Bícha
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 8
Merged at revision: 9
Proposed branch: lp://qastaging/~jbicha/checkbox/update-vcs-link
Merge into: lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp://qastaging/~jbicha/checkbox/update-vcs-link
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+172416@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I'm not sure this is right. Trunk is where the code is, checkbox-packaging has just the debian/ directory (and gets combined with the rest using a Launchpad recipe). Which URL should be used there?

review: Needs Information
Revision history for this message
Jeremy Bícha (jbicha) wrote :

According to Debian policy, the Vcs field should point to the packaging repository.

Compare with https://bazaar.launchpad.net/~ubuntu-desktop/gnome-control-center/ubuntu/view/head:/debian/control.in which is also a packaging-only repository.

On the other hand I think it is a bit unusual to have a packaging-only repository for a "native" package.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

We're trying to become a less native package. This repository is used for
daily builds. The actual package is in checkbox-old/debian but it does not
cover the whole distribution. We need to clean some of that stuff up and
probably transition to a non-native package with one external packaging
branch that covers all of the sub-projects of checkbox.

Given what you said I think it's okay to merge this.

On Tue, Jul 2, 2013 at 4:12 PM, Jeremy Bicha <email address hidden> wrote:

> According to Debian policy, the Vcs field should point to the packaging
> repository.
>
> Compare with
> https://bazaar.launchpad.net/~ubuntu-desktop/gnome-control-center/ubuntu/view/head:/debian/control.inwhich is also a packaging-only repository.
>
> On the other hand I think it is a bit unusual to have a packaging-only
> repository for a "native" package.
> --
> https://code.launchpad.net/~jbicha/checkbox/update-vcs-link/+merge/172416
> You are reviewing the proposed merge of
> lp:~jbicha/checkbox/update-vcs-link into
> lp:~checkbox-dev/checkbox/checkbox-packaging.
>

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches