Merge lp://qastaging/~jbicha/libunity/use-vala-0.16-instead-of-0.18 into lp://qastaging/libunity

Proposed by Jeremy Bícha
Status: Rejected
Rejected by: Michal Hruby
Proposed branch: lp://qastaging/~jbicha/libunity/use-vala-0.16-instead-of-0.18
Merge into: lp://qastaging/libunity
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp://qastaging/~jbicha/libunity/use-vala-0.16-instead-of-0.18
Reviewer Review Type Date Requested Status
Michal Hruby (community) Disapprove
Review via email: mp+179602@code.qastaging.launchpad.net

Commit message

Build-depend on valac-0.16 instead of 0.18

Description of the change

This is 1 of only 2 packages in main depending on vala-0.18 (which has already been dropped from Debian). The other is libfriends (bug 1194211).

We'll probably be able to port all the universe vala-0.18 rdepends to vala 0.20 for Saucy so this is the only thing keeping vala-0.18 in Saucy at all. But it will take a bit longer to drop vala 0.16 from Ubuntu.

This is just a temporary workaround since libunity doesn't build against the default vala (0.20) yet (bug 1189616).

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Valac 0.16 is too old, libunity wouldn't even work without code changes.

review: Disapprove

Unmerged revisions

275. By Jeremy Bícha

Build-depend on valac-0.16 instead of valac-0.18

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches