Unity Asset Pool

Merge lp://qastaging/~jbicha/unity-asset-pool/drop-obsolete-icons into lp://qastaging/unity-asset-pool

  1. drop-obsolete-icons
  2. Merge into trunk
Proposed by Jeremy Bícha
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 85
Merged at revision: 84
Proposed branch: lp://qastaging/~jbicha/unity-asset-pool/drop-obsolete-icons
Merge into: lp://qastaging/unity-asset-pool
Diff against target: 108 lines (+8/-4)
3 files modified
debian/changelog (+7/-0)
debian/control (+1/-1)
debian/install (+0/-3)
To merge this branch: bzr merge lp://qastaging/~jbicha/unity-asset-pool/drop-obsolete-icons
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Iain Lane Approve
Review via email: mp+323724@code.qastaging.launchpad.net

Commit message

Drop account-plugin-icons (Empathy no longer supports UOA)
Drop unity-webapps icons to allow them to be shipped by the webapps directly

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

What's the reason for doing this out of order with the removal?

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Right. This probably shouldn't land until whatever webapp implementation ships its own icon first. I needed it for my testing PPA if I wanted to reuse the existing icon name (useful for some "extreme" third-party themes) so I put it in bileto for holding.

I guess I should change the status here to WIP instead of Needs Review?

Revision history for this message
Iain Lane (laney) wrote :

Let's do this now. Thanks!

In the same silo we should upload Unity to drop the launcher I think. And I might as well put ubuntu-settings (the new webapp) in there. The package removals can happen at a later date but we should make sure to not forget about them.

review: Approve
Revision history for this message
Jeremy Bícha (jbicha) wrote :

The silo is https://bileto.ubuntu.com/#/ticket/2755

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Unless it's easier for you to make your own silo?

Revision history for this message
Iain Lane (laney) wrote :

I'm putting unity, webapps-applications, ubuntu-settings in there too. The first two (especially the second one) are for tidying up and the third holds the new launcher for Shell. I had uploaded that before but I messed up the paths for the icon theme so it wouldn't have worked once u-a-p dropped the icons.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: