Merge lp://qastaging/~jcsackett/launchpad/620494-downloads-sort into lp://qastaging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Aaron Bentley |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11435 |
| Proposed branch: | lp://qastaging/~jcsackett/launchpad/620494-downloads-sort |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
69 lines (+40/-1) 2 files modified
lib/lp/registry/model/product.py (+8/-1) lib/lp/registry/tests/test_product.py (+32/-0) |
| To merge this branch: | bzr merge lp://qastaging/~jcsackett/launchpad/620494-downloads-sort |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fixes sorting on plus download by adding milestone name as an additional sort parameter.
Description of the change
= Summary =
Fixes an edge case sorting releases on +download by adding an additional sort field. Per the bug, if too releases have the same date, they can be sorted wrong from the fallback to database id.
== Proposed fix ==
Add an additional sort by milestone.name; this catches the edge case and displays the releases correctly since most milestones use numeric names.
== Pre-implementation notes ==
Talked with Curtis.
== Implementation details ==
As in Proposed fix.
== Tests ==
bin/test -vvc -t getMilestonesAn
== Demo and Q/A ==
On Thunderbird in dev (launchpad.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
| Aaron Bentley (abentley) | # |
| Robert Collins (lifeless) wrote | # |
I think that someone is adding a database sort function for milestone
names anyhow; you should probably use that.