bzr-grep

Merge lp://qastaging/~jdahlin-deactivatedaccount/bzr-grep/color-option into lp://qastaging/bzr-grep

  1. color-option
  2. Merge into trunk
Proposed by Johan Dahlin
Status: Merged
Approved by: Parth Malwankar
Approved revision: 144
Merged at revision: 144
Proposed branch: lp://qastaging/~jdahlin-deactivatedaccount/bzr-grep/color-option
Merge into: lp://qastaging/bzr-grep
Diff against target: 35 lines (+10/-1)
1 file modified
cmds.py (+10/-1)
To merge this branch: bzr merge lp://qastaging/~jdahlin-deactivatedaccount/bzr-grep/color-option
Reviewer Review Type Date Requested Status
Parth Malwankar Approve
Jelmer Vernooij (community) code Approve
Review via email: mp+64988@code.qastaging.launchpad.net

Description of the change

This adds a global option so you don't have to type --color=auto all the time.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This seems reasonable, though it would be nice to have a test for the option.

review: Approve (code)
Revision history for this message
Johan Dahlin (jdahlin-deactivatedaccount) wrote :

I don't have the necessary permissions to merge it into lp:bzr-grep.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Johan,

On 28/06/11 15:51, Johan Dahlin wrote:
> I don't have the necessary permissions to merge it into lp:bzr-grep.
 I don't have access either. Hopefully Parth will be able to review and
merge it.

Cheers,

Jelmer

Revision history for this message
Parth Malwankar (parthm) wrote :

Thanks for the patch Johan.

Sorry for the delay. Things are a little crazy at work. I will do the merge this weekend.
Could you please make a NEWS entry for this enhancement?

I am not sure why we have a permissions issue as the project maintainer is set to Bazaar Developers (~bzr).

Regards,
Parth

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: