Merge into trunk.14.10 : indicator-network-lp1296415 : Code : Network Menu

Status:

Rejected

Rejected by:

Charles Kerr on 2014-07-17

Proposed branch:

lp://qastaging/~jdstrand/indicator-network/indicator-network-lp1296415

Merge into:

lp://qastaging/indicator-network/14.10

Diff against target:

59 lines (+23/-0)

5 files modified

debian/control (+1/-0)
debian/indicator-network.dirs (+1/-0)
debian/indicator-network.install (+1/-0)
debian/rules (+4/-0)
debian/usr.lib.indicator-network-service (+16/-0)

To merge this branch:

bzr merge lp://qastaging/~jdstrand/indicator-network/indicator-network-lp1296415

Wishlist

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-06-24
Indicator Applet Developers		2014-06-24	Pending
Review via email: mp+224364@code.qastaging.launchpad.net

Commit message

   * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
     - add debian/usr.lib.indicator-network-service
     - debian/control: Build-Depends on dh-apparmor
     - debian/rules: update override_dh_installdeb to use dh_apparmor
     - debian/indicator-network.dirs: add etc/apparmor.d
     - debian/indicator-network.install: install profile in to place

Description of the change

   * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
     - add debian/usr.lib.indicator-network-service
     - debian/control: Build-Depends on dh-apparmor
     - debian/rules: update override_dh_installdeb to use dh_apparmor
     - debian/indicator-network.dirs: add etc/apparmor.d
     - debian/indicator-network.install: install profile in to place

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-24:

#

PASSED: Continuous integration, rev:350
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/145/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-armhf-ci/19/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/145/rebuild

review: Approve (continuous-integration)

lp://qastaging/~jdstrand/indicator-network/indicator-network-lp1296415 updated on 2014-06-24

351. By Jamie Strandboge on 2014-06-24: debian/usr.lib.indicator-network-service: more closely mimic unconfined with
exec transitions

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-24:

#

PASSED: Continuous integration, rev:351
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/146/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-amd64-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-utopic-armhf-ci/20/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/146/rebuild

review: Approve (continuous-integration)

Revision history for this message

Jamie Strandboge (jdstrand) wrote on 2014-07-17:

#

Please reject this. We won't be implementing this feature after all (see bug description for more info).

Revision history for this message

Charles Kerr (charlesk) wrote on 2014-07-17:

#

Rejecting as per Jamie's request

Unmerged revisions

351. By Jamie Strandboge on 2014-06-24: debian/usr.lib.indicator-network-service: more closely mimic unconfined with
exec transitions
350. By Jamie Strandboge on 2014-06-24: * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
   - add debian/usr.lib.indicator-network-service
   - debian/control: Build-Depends on dh-apparmor
   - debian/rules: update override_dh_installdeb to use dh_apparmor
   - debian/indicator-network.dirs: add etc/apparmor.d
   - debian/indicator-network.install: install profile in to place

Network Menu

Merge lp://qastaging/~jdstrand/indicator-network/indicator-network-lp1296415 into lp://qastaging/indicator-network/14.10

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers