Merge lp://qastaging/~jelmer/bzr-commitfromnews/extractbugnumbers into lp://qastaging/bzr-commitfromnews

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 3
Proposed branch: lp://qastaging/~jelmer/bzr-commitfromnews/extractbugnumbers
Merge into: lp://qastaging/bzr-commitfromnews
Diff against target: 158 lines (+72/-27)
2 files modified
committemplate.py (+14/-1)
tests/test_committemplate.py (+58/-26)
To merge this branch: bzr merge lp://qastaging/~jelmer/bzr-commitfromnews/extractbugnumbers
Reviewer Review Type Date Requested Status
Robert Collins Pending
Review via email: mp+84953@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2010-03-30.

Description of the change

Initial work on setting revision properties based on information in NEWS.

Now updated to use "lp:BUGNO" rather than "#BUGNO"

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote : Posted in a previous version of this proposal

 review: needsfixing

This is looking pretty good. Uhm, I don't like #1234 being picked up -
lets look for lp:1234 - that way we don't have any confusion about what
bug tracker. And yes, I think that that will matter a great deal.

You can introspect bzr's bugs module to get a list of prefixes that can
be looked for sensibly, pretty easily.

Cheers,
Rob

review: Needs Fixing
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Updated. This now uses lp:1234 to talk about Launchpad bug numbers. It wasn't quite as easy to handle other bug trackers too, so I've kept it Launchpad-specific for now, but adding support for the other bug trackers should be possible without changing the behaviour for lp-specific bugs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches