Bazaar-cvs

Merge lp://qastaging/~jelmer/bzr-cvs/check-status into lp://qastaging/bzr-cvs

  1. check-status
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 6
Merged at revision: 6
Proposed branch: lp://qastaging/~jelmer/bzr-cvs/check-status
Merge into: lp://qastaging/bzr-cvs
Diff against target: 31 lines (+8/-5)
1 file modified
__init__.py (+8/-5)
To merge this branch: bzr merge lp://qastaging/~jelmer/bzr-cvs/check-status
Reviewer Review Type Date Requested Status
Vincent Ladeuil Approve
Review via email: mp+53245@code.qastaging.launchpad.net

Description of the change

Companion branch to lp:~jelmer/bzr/notsupported-check; return False in CVSDirFormat.is_supported() but implement a check_supported() call that raises a custom exception that explains what to do with CVS checkouts.

(This will probably need some updating after check_status() in lp:~jelmer/bzr/notsupported-check is renamed)

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/14/2011 2:59 PM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-cvs/check-status into lp:bzr-cvs.
>
> Requested reviews:
> Bazaar Developers (bzr)
> Related bugs:
> Bug #731311 in Bazaar: "support custom UnsupportedFormat errors"
> https://bugs.launchpad.net/bzr/+bug/731311
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-cvs/check-status/+merge/53245
>
> Companion branch to lp:~jelmer/bzr/notsupported-check; return False in CVSDirFormat.is_supported() but implement a check_supported() call that raises a custom exception that explains what to do with CVS checkouts.
>
> (This will probably need some updating after check_status() in lp:~jelmer/bzr/notsupported-check is renamed)

Approved, of course pending any renames of the 'check_status' function.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1+MeQACgkQJdeBCYSNAANleACfTOr9iOFDK4ZuIxga1LT+c3Da
J0sAoImMQglm13DqpBWqRw0DsLXCwA4M
=qzYh
-----END PGP SIGNATURE-----

Revision history for this message
Vincent Ladeuil (vila) wrote :

voting approve for jam to ease tracking

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: