Merge lp://qastaging/~jelmer/bzr-dbus/lazy-hooks into lp://qastaging/bzr-dbus

Proposed by Jelmer Vernooij
Status: Merged
Approved by: John A Meinel
Approved revision: 48
Merged at revision: 48
Proposed branch: lp://qastaging/~jelmer/bzr-dbus/lazy-hooks
Merge into: lp://qastaging/bzr-dbus
Diff against target: 89 lines (+41/-22)
2 files modified
__init__.py (+41/-3)
hook.py (+0/-19)
To merge this branch: bzr merge lp://qastaging/~jelmer/bzr-dbus/lazy-hooks
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+55537@code.qastaging.launchpad.net

Commit message

Lazily register hooks if possible.

Description of the change

Lazily register hooks if supported by the version of bzrlib used.

This avoids loading of the smart server unless it's actually used.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/31/2011 5:03 PM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-dbus/lazy-hooks into lp:bzr-dbus.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-dbus/lazy-hooks/+merge/55537
>
> Lazily register hooks if supported by the version of bzrlib used.
>
> This avoids loading of the smart server unless it's actually used.

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2UmPsACgkQJdeBCYSNAAOTFwCgs22JedZ6mZOPR1T5anDpf18r
1E8AoL+E71X2zB+Ws50ZmBIton8PfDyW
=8x7X
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches