Bazaar GTK+ Frontends

Merge lp://qastaging/~jelmer/bzr-gtk/remove-bzr-notify into lp://qastaging/bzr-gtk

  1. remove-bzr-notify
  2. Merge into gtk3
Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 794
Proposed branch: lp://qastaging/~jelmer/bzr-gtk/remove-bzr-notify
Merge into: lp://qastaging/bzr-gtk
Diff against target: 462 lines (+9/-377)
9 files modified
NEWS (+6/-0)
bzr-notify (+0/-102)
bzr-notify.desktop (+0/-12)
bzr-notify.desktop.in (+0/-10)
notify.py (+0/-104)
preferences/__init__.py (+1/-3)
preferences/notifications.py (+0/-79)
setup.py (+2/-3)
tests/test_notify.py (+0/-64)
To merge this branch: bzr merge lp://qastaging/~jelmer/bzr-gtk/remove-bzr-notify
Reviewer Review Type Date Requested Status
Vincent Ladeuil Disapprove
Curtis Hovey (community) code Approve
Review via email: mp+113990@code.qastaging.launchpad.net

Description of the change

Stop shipping bzr-notify.

bzr-notify never really reached its potential - it was meant to notify about background bzr jobs, and commits that happened on the local lan (integrated with bzr-avahi).

There are several open bugs about bzr-notify and it's causing far more harm than good at the moment. Nobody has actively done anything to improve bzr-notify in a long time, so I think we should just remove it.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

I think this is the right decision. Thank you.

review: Approve (code)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Hold on, I'm still using that, can't we just disable it by default instead (with instructions on how to enable it ;)

review: Disapprove
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> Hold on, I'm still using that, can't we just disable it by default instead
> (with instructions on how to enable it ;)
Do we really want to keep something around that's mostly broken though? I wouldn't want any new users picking it up, especially given it's fair number of issues. It's just an extra maintenance burden.

Revision history for this message
Vincent Ladeuil (vila) wrote :

'mostly broken' seems slightly excessive given that it just works here.

I have never been able to reproduce bug #949798 myself (I witnessed it once or twice but it was long ago).

Revision history for this message
Curtis Hovey (sinzui) wrote :

Removing this feature will also fix these Ubuntu package bugs:
    Bug #919886, Bug #315741, Bug #1001679, Bugs Bug #983830, Bug #925933
and these additional bzr-gtk bugs:
    Bug #159113, Bug #107169,

I think bzr-notify is too brittle. It does not "just work". This could be a separate project and the bugs can be moved to it. Users who want the feature can install it instead of getting errors for a feature they have not asked for.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Maybe 'mostly broken' is an exaggeration, but it's far from stable and it causes a fair few problems. Given we don't really have the resources to address those issues, do we really want to keep shipping something that has this many problems, and so little real use?

lp://qastaging/~jelmer/bzr-gtk/remove-bzr-notify updated
795. By Jelmer Vernooij

Remove tests and preferences page.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: