Bazaar Keywords Plugin

Merge lp://qastaging/~jelmer/bzr-keywords/lazy into lp://qastaging/bzr-keywords

lazy
Merge into trunk

Proposed by Jelmer Vernooij on 2011-02-27

Status:	Merged
Approved by:	John A Meinel on 2011-03-02
Approved revision:	no longer in the source branch.
Merged at revision:	18
Proposed branch:	lp://qastaging/~jelmer/bzr-keywords/lazy
Merge into:	lp://qastaging/bzr-keywords
Diff against target:	652 lines (+294/-266) 4 files modified __init__.py (+23/-258) keywords.py (+264/-0) tests/test_conversion.py (+4/-1) tests/test_keywords_in_trees.py (+3/-7)
To merge this branch:	bzr merge lp://qastaging/~jelmer/bzr-keywords/lazy
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
John A Meinel		Needs Information on 2011-03-02
Martin Pool (community)	2011-02-27	Approve on 2011-03-02
Review via email: mp+51444@code.qastaging.launchpad.net

Description of the change

Lazily load the keywords plugin.

Revision history for this message

Martin Pool (mbp) on 2011-03-02:

review: Approve

Revision history for this message

John A Meinel (jameinel) wrote on 2011-03-02:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/27/2011 4:57 AM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-keywords/lazy into lp:bzr-keywords.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-keywords/lazy/+merge/51444
>
> Lazily load the keywords plugin.

I'm a bit surprised at how much code is added here, versus how much is
removed.
All the format_date, extract_name, etc don't seem to come from somewhere
else.

Is this just a large rewrite of the internals?

The changes seem fine to me, but I didn't go over them in detail, with
the change being surprisingly large.

Care to explain a bit more what you changed?

review: needsinfo

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1uFfAACgkQJdeBCYSNAAPKpQCcD0EpuFviTVfxSMY5ikxIwPrW
KV8AoIGp7aUs4DDgGztSHhpYnyzoNk5l
=3j0u
-----END PGP SIGNATURE-----

review: Needs Information

Revision history for this message

Jelmer Vernooij (jelmer) wrote on 2011-03-02:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 2/27/2011 4:57 AM, Jelmer Vernooij wrote:
> > Jelmer Vernooij has proposed merging lp:~jelmer/bzr-keywords/lazy into lp
> :bzr-keywords.
> >
> > Requested reviews:
> > Bazaar Developers (bzr)
> >
> > For more details, see:
> > https://code.launchpad.net/~jelmer/bzr-keywords/lazy/+merge/51444
> >
> > Lazily load the keywords plugin.
>
> I'm a bit surprised at how much code is added here, versus how much is
> removed.
> All the format_date, extract_name, etc don't seem to come from somewhere
> else.
>
> Is this just a large rewrite of the internals?
>
> The changes seem fine to me, but I didn't go over them in detail, with
> the change being surprisingly large.
>
> Care to explain a bit more what you changed?
There was a conflict with some earlier changes, which caused the code I moved around to stay in __init__.py in the conflicts. Should be fixed now.