Merge lp://qastaging/~jelmer/bzr-pqm/lp-land-supports-child_pqm_email into lp://qastaging/bzr-pqm
Proposed by
Jelmer Vernooij
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 82 | ||||
| Proposed branch: | lp://qastaging/~jelmer/bzr-pqm/lp-land-supports-child_pqm_email | ||||
| Merge into: | lp://qastaging/bzr-pqm | ||||
| Diff against target: |
78 lines (+23/-12) 2 files modified
lpland.py (+4/-4) pqm_submit.py (+19/-8) |
||||
| To merge this branch: | bzr merge lp://qastaging/~jelmer/bzr-pqm/lp-land-supports-child_pqm_email | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Pool (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Factor out the code that determines the e-mail address of PQM out of "bzr pqm-subnmit", and use it in "bzr lp-land" too.
This fixes the support in lp-land for looking at the "child_pqm_email" configuration option set in the submission branch.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
thanks
this makes me wonder if, separately, the config infrastructure should
support the general "if not set raise an error of class e", perhaps
including the context where it was looked up.
vote approve