Merge lp://qastaging/~jelmer/bzr-service/trace-import-errors into lp://qastaging/bzr-service
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Merged at revision: | 19 |
Proposed branch: | lp://qastaging/~jelmer/bzr-service/trace-import-errors |
Merge into: | lp://qastaging/bzr-service |
Diff against target: |
13 lines (+1/-2) 1 file modified
service.py (+1/-2) |
To merge this branch: | bzr merge lp://qastaging/~jelmer/bzr-service/trace-import-errors |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bazaar Developers | Pending | ||
Review via email: mp+52277@code.qastaging.launchpad.net |
Description of the change
bzr start-service is currently a bit chatty about modules that could not be imported. These are generally harmless and because of e.g. missing dependencies that are expected. This patch makes it mutter rather than note import failures.
Of course, when something later tries the import it will just be tried again and it'll have to deal with an ImportError as usual.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 3/5/2011 3:03 AM, Jelmer Vernooij wrote: /bugs.launchpad .net/bugs/ 538466 /code.launchpad .net/~jelmer/ bzr-service/ trace-import- errors/ +merge/ 52277
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-service/trace-import-errors into lp:bzr-service.
>
> Requested reviews:
> Bazaar Developers (bzr)
> Related bugs:
> #538466 failed to import bzrlib.strace No module named testtools
> https:/
>
> For more details, see:
> https:/
>
> bzr start-service is currently a bit chatty about modules that could not be imported. These are generally harmless and because of e.g. missing dependencies that are expected. This patch makes it mutter rather than note import failures.
>
> Of course, when something later tries the import it will just be tried again and it'll have to deal with an ImportError as usual.
not that this is a super-active plugin anymore...
But "trace.trace" doesn't look like it will work. I think you meant
"trace.mutter".
At which point,
merge:approve
But tweak it, first.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
01fgACgkQJdeBCY SNAAObYwCgji2jl 1O8isVCVb/ p/P8Ax8XS rLh3SNLSSgepE1r zU
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
MisAoMJqZHJHEek
=ptue
-----END PGP SIGNATURE-----