Merge lp://qastaging/~jelmer/bzr-service/trace-import-errors into lp://qastaging/bzr-service

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 19
Proposed branch: lp://qastaging/~jelmer/bzr-service/trace-import-errors
Merge into: lp://qastaging/bzr-service
Diff against target: 13 lines (+1/-2)
1 file modified
service.py (+1/-2)
To merge this branch: bzr merge lp://qastaging/~jelmer/bzr-service/trace-import-errors
Reviewer Review Type Date Requested Status
Bazaar Developers Pending
Review via email: mp+52277@code.qastaging.launchpad.net

Description of the change

bzr start-service is currently a bit chatty about modules that could not be imported. These are generally harmless and because of e.g. missing dependencies that are expected. This patch makes it mutter rather than note import failures.

Of course, when something later tries the import it will just be tried again and it'll have to deal with an ImportError as usual.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/5/2011 3:03 AM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-service/trace-import-errors into lp:bzr-service.
>
> Requested reviews:
> Bazaar Developers (bzr)
> Related bugs:
> #538466 failed to import bzrlib.strace No module named testtools
> https://bugs.launchpad.net/bugs/538466
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-service/trace-import-errors/+merge/52277
>
> bzr start-service is currently a bit chatty about modules that could not be imported. These are generally harmless and because of e.g. missing dependencies that are expected. This patch makes it mutter rather than note import failures.
>
> Of course, when something later tries the import it will just be tried again and it'll have to deal with an ImportError as usual.

not that this is a super-active plugin anymore...

But "trace.trace" doesn't look like it will work. I think you meant
"trace.mutter".

At which point,
  merge:approve

But tweak it, first.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk101fgACgkQJdeBCYSNAAObYwCgji2jl1O8isVCVb/p/P8Ax8XS
MisAoMJqZHJHEekrLh3SNLSSgepE1rzU
=ptue
-----END PGP SIGNATURE-----

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Sorry, I pushed the wrong branch - the MP should have the correct diff now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: