Merge lp://qastaging/~jelmer/bzr/733612-deprecated-graph into lp://qastaging/bzr

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/21/2011 4:45 PM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr/733612-deprecated-graph into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> Bug #733612 in Bazaar: "bzrlib.deprecated_graph is unused"
> https://bugs.launchpad.net/bzr/+bug/733612
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr/733612-deprecated-graph/+merge/58689
>
> Remove bzrlib.deprecated_graph.
>
> I think we can remove this directly since it's "evil" (requires full graph access), and its name already indicates it is deprecated. It isn't used anywhere in bzrlib.
>
> bzrtools still uses it but I have a patch that re-adds this code in bzrtools for the time being.

I don't see the patch on bzrtools, once that lands I think it is safe to
land this. I'd rather wait for bzrtools to get the update first, if that
isn't too onerous.

John
=:->

 review: approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk25nX8ACgkQJdeBCYSNAAORxACePzUoY8+O5ICv7/nojbAAcbHX
HQAAoJwX+PNYshMpi3HCRi+h37RQAimE
=g4UI
-----END PGP SIGNATURE-----

On Thu, 2011-04-28 at 19:01 +0200, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 4/21/2011 4:45 PM, Jelmer Vernooij wrote:
> > Jelmer Vernooij has proposed merging lp:~jelmer/bzr/733612-deprecated-graph into lp:bzr.
> >
> > Requested reviews:
> > bzr-core (bzr-core)
> > Related bugs:
> > Bug #733612 in Bazaar: "bzrlib.deprecated_graph is unused"
> > https://bugs.launchpad.net/bzr/+bug/733612
> >
> > For more details, see:
> > https://code.launchpad.net/~jelmer/bzr/733612-deprecated-graph/+merge/58689
> >
> > Remove bzrlib.deprecated_graph.
> >
> > I think we can remove this directly since it's "evil" (requires full graph access), and its name already indicates it is deprecated. It isn't used anywhere in bzrlib.
> >
> > bzrtools still uses it but I have a patch that re-adds this code in bzrtools for the time being.
>
> I don't see the patch on bzrtools, once that lands I think it is safe to
> land this. I'd rather wait for bzrtools to get the update first, if that
> isn't too onerous.
FWIW I've now proposed the bzrtools merge:

https://code.launchpad.net/~jelmer/bzrtools/no-deprecated-graph/+merge/59486

I'll wait for that to land before landing this patch.

Thanks for the review :)

Jelmer

Marking as wip to clear the queue, feel free to land when appropriate.