BzrTools

Merge lp://qastaging/~jelmer/bzrtools/no-more-branches into lp://qastaging/bzrtools

  1. no-more-branches
  2. Merge into bzrtools.dev
Proposed by Jelmer Vernooij
Status: Rejected
Rejected by: Aaron Bentley
Proposed branch: lp://qastaging/~jelmer/bzrtools/no-more-branches
Merge into: lp://qastaging/bzrtools
Diff against target: 313 lines (+17/-91)
13 files modified
__init__.py (+0/-1)
branches.py (+0/-12)
bzrtools.py (+6/-33)
cbranch.py (+0/-1)
command_classes.py (+0/-18)
heads.py (+1/-2)
hunk_selector.py (+1/-1)
patch.py (+1/-2)
progress.py (+0/-2)
rspush.py (+0/-2)
shelf.py (+2/-3)
tests/blackbox.py (+0/-13)
tests/test_link_tree.py (+6/-1)
To merge this branch: bzr merge lp://qastaging/~jelmer/bzrtools/no-more-branches
Reviewer Review Type Date Requested Status
Jonathan Riddell (community) Approve
Aaron Bentley Pending
Review via email: mp+73276@code.qastaging.launchpad.net

Description of the change

Remove the implementation of the 'bzr branches' command, which should
be available as 'bzr branches --scan' in bzr 2.5.

To post a comment you must log in.
Revision history for this message
Jonathan Riddell (jr) wrote :

Looks fine

review: Approve
Revision history for this message
Aaron Bentley (abentley) wrote :

Jonathan, I actually have misgivings about removing the command entirely, which is why I haven't gone ahead and merged it. Bzrtools is mostly backwards-compatible with older bzrs and I don't know if I want to remove a command that they could use and have traditionally had.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hmm, I can't seem to mark my own MPs as rejected.

Revision history for this message
Aaron Bentley (abentley) wrote :

What's the deal with --scan? I don't want to mask the bzr version of 'branches', but I don't want to remove the bzrtools version if there's no reasonable alternative.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

"bzr branches --recursive" (renamed from --scan) has now landed on bzr.dev, and provides similar functionality to "bzr branches" from bzrtools.

Revision history for this message
Aaron Bentley (abentley) wrote :

Okay, so I think the strategy should be for "list-branches" to recomment "branches --recursive" in bzrs that have it.

Revision history for this message
Aaron Bentley (abentley) wrote :

recommend, not recomment.

Unmerged revisions

779. By Jelmer Vernooij

Remove implementation of branches command, which now is "bzr branches --scan".

778. By Jelmer Vernooij

Merge fix-bzr.dev-compat.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches