Launchpad itself

Merge lp://qastaging/~jelmer/launchpad/608846-make-lp-user-ssh-keys into lp://qastaging/launchpad

  1. 608846-make-lp-user-ssh-keys
  2. Merge into devel
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 11207
Proposed branch: lp://qastaging/~jelmer/launchpad/608846-make-lp-user-ssh-keys
Merge into: lp://qastaging/launchpad
Diff against target: 30 lines (+4/-4)
1 file modified
utilities/make-lp-user (+4/-4)
To merge this branch: bzr merge lp://qastaging/~jelmer/launchpad/608846-make-lp-user-ssh-keys
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+30701@code.qastaging.launchpad.net

Commit message

Update make-lp-user to use new ISSHKeySet.new() API.

Description of the change

This trivial branch fixes make-lp-user's call to ISSHKeySet.new() after the latters' arguments have been changed.

utilities/soyuz-sampledata-setup.py uses make-lp-user and this bug blocks it from being usable.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Perhaps the heavylifting in make-lp-user should be moved into the lp. namespace so it can be unittested. I'll leave that for a separate bug though.

Revision history for this message
Robert Collins (lifeless) wrote :

agreed, please do test it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.