Merge lp://qastaging/~jelmer/launchpad/buildrecipe-allow-fallback-to-native into lp://qastaging/launchpad

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 14262
Proposed branch: lp://qastaging/~jelmer/launchpad/buildrecipe-allow-fallback-to-native
Merge into: lp://qastaging/launchpad
Diff against target: 13 lines (+2/-1)
1 file modified
lib/canonical/buildd/buildrecipe (+2/-1)
To merge this branch: bzr merge lp://qastaging/~jelmer/launchpad/buildrecipe-allow-fallback-to-native
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+81271@code.qastaging.launchpad.net

Commit message

[r=bac][bug=885497] Pass --allow-fallback-to-native to "bzr dailydeb".

Description of the change

Pass --allow-fallback-to-native to "bzr dailydeb".

At the moment, Launchpad runs a version of bzr-builder that converts *all*
non-native source packages to native packages.

Newer versions of bzr-builder support properly building non-native packages too,
and by default no longer convert non-native packages to native packages.
Instead, bzr-builder actually attempts to build a propery native package.

Since building a native package requires an orig tarball, most of the
existing builds on Launchpad can't actually be built as a non-native package.
And because they're daily builds, it makes more sense to build them as
a native package too. The reason some try to build a non-native is
because they inherit their packaging data from Debian or Ubuntu packages.

Passing --allow-fallback-to-native makes bzr dailydeb keep the old
behaviour of converting non-native packages to native packages,
but only if no upstream tarball was found.

This will need to be deployed together with the new version of bzr-builder,
which is already available in the cat archive,
as old versions don't have the --allow-fallback-to-native option.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the nice explanation -- looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.