Merge lp://qastaging/~jelmer/launchpad/publisher-use-debian-1 into lp://qastaging/launchpad

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 11404
Proposed branch: lp://qastaging/~jelmer/launchpad/publisher-use-debian-1
Merge into: lp://qastaging/launchpad
Diff against target: 211 lines (+62/-68)
2 files modified
lib/lp/archivepublisher/publishing.py (+61/-67)
lib/lp/soyuz/doc/soyuz-upload.txt (+1/-1)
To merge this branch: bzr merge lp://qastaging/~jelmer/launchpad/publisher-use-debian-1
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+32245@code.qastaging.launchpad.net

Commit message

Use python-debian to generate Release files in the archivepublisher.

Description of the change

Refactor lp.archivepublisher.publishing to use the functionality in the new "debian" Python module to generate Release files, rather than using hardcoded strings.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I haven't done a pre-implementation call about this specific change, although I have discussed moving towards more use of python-debian (which is an upstream project maintained by various Debian and Ubuntu developers) with Julian in the past.

I'm about to make some more changes to this particular part of the code, and it seemed like a good idea to refactor first and use python-debian's infrastructure so that I don't have to worry about the serialization of newly introduced fields.

Tests: ./bin/test lp.archivepublisher

I've fixed all remaining lint issues.

Revision history for this message
Brad Crittenden (bac) wrote :

Very nice branch Jelmer. Please use a more descriptive loop variable than "f", especially since it is used again a little later as a file descriptor. Recall our coding guidelines strongly discourage single letter variables, even in loops.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.