Code review comment for lp://qastaging/~jelmer/launchpad/publisher-use-debian-1

Revision history for this message
Brad Crittenden (bac) wrote :

Very nice branch Jelmer. Please use a more descriptive loop variable than "f", especially since it is used again a little later as a file descriptor. Recall our coding guidelines strongly discourage single letter variables, even in loops.

review: Approve (code)

« Back to merge proposal