Files

Merge lp://qastaging/~jeremywootten/pantheon-files/fix-1176471-folder-properties into lp://qastaging/~elementary-apps/pantheon-files/trunk

  1. fix-1176471-folder-properties
  2. Merge into trunk
Proposed by Jeremy Wootten
Status: Merged
Approved by: Felipe Escoto
Approved revision: 2055
Merged at revision: 2104
Proposed branch: lp://qastaging/~jeremywootten/pantheon-files/fix-1176471-folder-properties
Merge into: lp://qastaging/~elementary-apps/pantheon-files/trunk
Diff against target: 465 lines (+215/-97)
1 file modified
src/View/PropertiesWindow.vala (+215/-97)
To merge this branch: bzr merge lp://qastaging/~jeremywootten/pantheon-files/fix-1176471-folder-properties
Reviewer Review Type Date Requested Status
Felipe Escoto (community) Approve
Review via email: mp+290833@code.qastaging.launchpad.net

Commit message

Show additional property information for folder selections (lp: 1176471)

Description of the change

This branch shows another information line when the selection consists only of folders. This line shows the how many subfolders and ordinary files were found on a deep count of the selected folder (s).

To post a comment you must log in.
Revision history for this message
Felipe Escoto (philip.scott) wrote :

Empty folders show

"Contains: "

review: Needs Fixing
lp://qastaging/~jeremywootten/pantheon-files/fix-1176471-folder-properties updated
2052. By Jeremy Wootten

Merge trunk to r2101

2053. By Jeremy Wootten

Deal better with empty folders

2054. By Jeremy Wootten

Hide 'Contains:' line for empty folders

Revision history for this message
Felipe Escoto (philip.scott) wrote :

I made some comments on code style, but now it's not appearing on my end for some reason :P

Revision history for this message
Jeremy Wootten (jeremywootten) :
lp://qastaging/~jeremywootten/pantheon-files/fix-1176471-folder-properties updated
2055. By Jeremy Wootten

Fix formatting; ensure contains label shows when appropriate

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

I have fixed the code format issues identified and also a previously unidentified bug causing the "Contains" line to sometimes be hidden inappropriately.

Revision history for this message
Felipe Escoto (philip.scott) wrote :

Perfect! Thank you :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: