Merge lp://qastaging/~jeremywootten/pantheon-files/transfer-popover-with-pie-progress into lp://qastaging/~elementary-apps/pantheon-files/trunk

I don't think we need to send a notification when cancelling a transfer. That's something that I just did. There's no delay between me doing it and it happening and it's obvious that it happened because the file is removed from the popover. So it seems unnecessary to send a notification here.

I don't really like that it warns you about closing the window now. That seems like a regression. Users should be able to close a window without worry and the process just continue to run in the background.

I also get notifications when moving things to the trash from an external disk. That seems unnecessary.

I get a notification on starting a transfer. Again, it seems unnecessary to notify me of things that I'm doing.

OK, thanks for your comments. I'll work on that.

The stop process button is now more clearly associated with the progress bar (not a close popover button) and is not symbolic - the red color warning that it has an irreversible effect (is confirmation required?). This follows comments on Google+.

No, I don't think confirmation is required. It is quite reversible. Just start another transfer :p

Notifications don't seen to have an icon. Probably should use the Files icon so it's clear which app this is coming from.

"File operation completed" is pretty vague. Can we get a little more specific? "5 files copied to Foo" for example?

I seem to always get the HTML mime. I'm guessing this is hardcoded?

Can the gradient on the progressbar go from top to bottom instead of around the doughnut? Looks kinda weird and doesn't really make sense. I'm not sure how the light would have to be to produce that effect :p

I'm thinking maybe we shouldn't group files into a single row. I have two rows that say "Copying foo files to bar". It's hard to remember what exactly each one is.

I'm not sure why you're creating constants for icon names, especially if you're only using it once. Seems like it makes the code less legible.

Any reason you're subclassing gtk.box here instead of using ListBox and ListBoxRow?

Margins on the popover seem oddly huge. Margins on dialogs and popovers should be 12px.

I think it would be helpful to name "ProgressInfoWidget.vala" something more indicative of what it actually is. It seems like that could mean just about anything. Something like "TransferRow" might be more clear about what it is used for and what shape it takes. "Widget" could be anything.

You should use gtk.grid instead of nesting boxes

The completion notification is "All file operations have been completed" and only appears when the last of the file operations finishes - there are no notifications for individual notifications for file operations. So your suggestion would only work if there was only one file operation (which, admittedly there usually is). Otherwise you would have to list each operation? And whether or not they were successful or failed? Or notify the ending of each operation individually?

Tested it. Works nicely, although the pie needs a bit of visual improvements to better match the mockup (https://github.com/elementary/mockups/blob/master/files/transfer.svg). I'll try and do those improvements myself if I have some time.

Diff comments attached to this message.