Merge lp://qastaging/~jeremywootten/pantheon-terminal/fix-1621637-same-tab-name-in-terminal into lp://qastaging/~elementary-apps/pantheon-terminal/trunk
Proposed by
Jeremy Wootten
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~jeremywootten/pantheon-terminal/fix-1621637-same-tab-name-in-terminal |
| Merge into: | lp://qastaging/~elementary-apps/pantheon-terminal/trunk |
| Diff against target: |
116 lines (+73/-8) 2 files modified
src/PantheonTerminalWindow.vala (+73/-1) src/TerminalWidget.vala (+0/-7) |
| To merge this branch: | bzr merge lp://qastaging/~jeremywootten/pantheon-terminal/fix-1621637-same-tab-name-in-terminal |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zisu Andrei | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-09-09.
Description of the change
Where two tabs are opened at different folders that have the same name, label the tabs in a way that distinguishes them.
In this branch, enough of the parent path needed to distinguish them is prepended to the tab-name.
However, because of the limited and fixed size of the tabs it is quite likely that the distinguishing parts of the name will not be visible on the tab and can only be seen in the tooltip displayed when the tab is hovered. It would be necessary to patch Granite.
To post a comment you must log in.
Revision history for this message
| Rico Tzschichholz (ricotz) wrote | # |
Revision history for this message
| Danielle Foré (danrabbit) wrote | # |
Unmerged revisions
- 896. By Jeremy Wootten
-
Merge trunk to r936
- 895. By Jeremy Wootten
-
Fix code style
- 894. By Jeremy Wootten
-
Deal with duplicate tab names with different paths
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Some comments inline.
Can you confirm this behavior isn't already present in trunk?