Media Hub

Merge lp://qastaging/~jhodapp/media-hub/orientation into lp://qastaging/media-hub

  1. orientation
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Approved
Approved by: Ricardo Salveti
Approved revision: 71
Proposed branch: lp://qastaging/~jhodapp/media-hub/orientation
Merge into: lp://qastaging/media-hub
Diff against target: 882 lines (+290/-22)
14 files modified
include/core/media/player.h (+14/-0)
src/core/media/codec.h (+40/-0)
src/core/media/engine.h (+3/-0)
src/core/media/gstreamer/bus.h (+1/-1)
src/core/media/gstreamer/engine.cpp (+41/-1)
src/core/media/gstreamer/engine.h (+3/-0)
src/core/media/gstreamer/meta_data_extractor.h (+1/-1)
src/core/media/gstreamer/playbin.h (+79/-5)
src/core/media/mpris/player.h (+17/-2)
src/core/media/player_implementation.cpp (+17/-1)
src/core/media/player_skeleton.cpp (+35/-7)
src/core/media/player_skeleton.h (+6/-0)
src/core/media/player_stub.cpp (+30/-4)
src/core/media/player_stub.h (+3/-0)
To merge this branch: bzr merge lp://qastaging/~jhodapp/media-hub/orientation
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+238355@code.qastaging.launchpad.net

Commit message

* Add an Orientation property which will indicate how the video should be rotated for playback vs how it was recorded.
* Get the video frame height/width from mirsink and pass it to the media-hub client via a Signal.

Description of the change

* Add an Orientation property which will indicate how the video should be rotated for playback vs how it was recorded.
* Get the video frame height/width from mirsink and pass it to the media-hub client via a Signal.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:70
http://jenkins.qa.ubuntu.com/job/media-hub-ci/142/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-amd64-ci/84
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/83
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/83/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-i386-ci/82/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/142/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~jhodapp/media-hub/orientation updated
71. By Jim Hodapp

Merged with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:71
http://jenkins.qa.ubuntu.com/job/media-hub-ci/143/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-amd64-ci/85
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/84
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/84/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-i386-ci/83

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/143/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM

review: Approve
Reply
lp://qastaging/~jhodapp/media-hub/orientation updated
72. By Jim Hodapp

Only get the video dimensions and signal the client of the dimensions changing when playing a video.

Unmerged revisions

72. By Jim Hodapp

Only get the video dimensions and signal the client of the dimensions changing when playing a video.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches