Merge lp://qastaging/~jibel/synaptic/bug.153966.452564 into lp://qastaging/synaptic
Proposed by
Jean-Baptiste Lallement
| Status: | Merged |
|---|---|
| Merged at revision: | 1771 |
| Proposed branch: | lp://qastaging/~jibel/synaptic/bug.153966.452564 |
| Merge into: | lp://qastaging/synaptic |
| Diff against target: |
224 lines (+123/-45) 3 files modified
common/rpackage.cc (+59/-32) common/rpackage.h (+3/-0) debian/patches/01_ubuntu_changelog.dpatch (+61/-13) |
| To merge this branch: | bzr merge lp://qastaging/~jibel/synaptic/bug.153966.452564 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| synaptic-developers | Pending | ||
|
Review via email:
|
|||
Description of the change
Tested with changelogs.
2 points still remains and need a fix:
- TODO: Need to use supportedOrigins instead of hard coded "Ubuntu". This is a problem for Debian.
- BUG: When pkgAcquire::Run() fails the item is not dequeued. Only visible if a changelog completely failed and the next succeeded, the messages are overwritten in the changelog dialog.
help would be much appreciated.
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks, diff looks good. For the todos:
1) is not too bad, the hardcoded value is there, but its all about LP, should prbably be a patch or a distro specific thing, but ok for now
2) sounds like a bug in libapt actually :/ Do you have steps to reproduce?