ubiquity

Merge ~jibel/ubiquity:advanced_features_dialog into ubiquity:master

  1. Git
  2. lp:~jibel/ubiquity
  3. advanced_features_dialog
  4. Merge into master
Proposed by Jean-Baptiste Lallement
Status: Merged
Merged at revision: 5a2667c9678e03f9a154cee3306b5204adb2a8d6
Proposed branch: ~jibel/ubiquity:advanced_features_dialog
Merge into: ubiquity:master
Diff against target: 561 lines (+308/-121)
6 files modified
debian/changelog (+2/-0)
debian/ubiquity.templates (+32/-0)
gui/gtk/stepPartAsk.ui (+211/-106)
tests/run-pep8 (+1/-0)
tests/test_gtkui.py (+3/-0)
ubiquity/plugins/ubi-partman.py (+59/-15)
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli (community) Approve
Steve Langasek Needs Information
Review via email: mp+374920@code.qastaging.launchpad.net

Commit message

New design for advanced features

A new dialog has been added to the guided partitioning page for advanced features. LVM, encrypted LVM and ZFS have been moved to this new dialog.

Specification:
https://docs.google.com/document/d/1bZ4yQIVgGaUGSYu3qiUHnQt3ieBZoqunP_DcleHCr3I/preview#heading=h.9wow0hy0pim7

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Jean-Baptiste Lallement (jibel) :
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I have nothing to add on the code changes themselves.

I have a done some tests with current 19.10 image + this branch on top of it. Apart from the selected translations still in english (but I see them in the template below and it makes sense to update the translations in a separate commits as discussed on IRC before the review), I didn't spot any major issues compared to the linked design.

Next/Back works as expected, even if going to the custom screen selection and back then (previous option still selected). However (and I checked that this isn't a regression from that MP), once pressing back from the custom screen, "Entire disk" is selected instead of "Something else". The previous advanced feature selection is still remembered though.

Just a note: there are some missing margins on the Cancel/OK buttons in the dialog compared to the spec.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

@didrocks thanks for the review.

I'll have a look at the next/back behaviour separately.
For the margins, they are the same than on the advanced partitioning dialog boxes but different than the partman confirmation dialog boxes for instance. I'll leave it like this and align all the margins in a separate MP.

for reference https://imgur.com/Ai6wKV4

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

with those additional info + a chat on IRC, I'm fine with the testing and it seems to align with ubiquity code style and mpt design.

+1 on my side. Just think about the followup commit to refresh templates. Thanks!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches