Juju Charms Collection
percona-cluster package

Merge lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-backup-action into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

  1. Trusty Tahr (14.04)
  2. add-backup-action
  3. Merge into next
Proposed by Jill Rouleau
Status: Superseded
Proposed branch: lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-backup-action
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 104 lines (+65/-4)
2 files modified
actions.yaml (+17/-1)
actions/actions.py (+48/-3)
To merge this branch: bzr merge lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-backup-action
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Billy Olsen Needs Fixing
Jorge Niedbalski (community) Approve
OpenStack Charmers Pending
Review via email: mp+270612@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2016-02-25.

Description of the change

Add actions for full and incremental backups.

To post a comment you must log in.
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

LGTM

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #8934 percona-cluster-next for jillrouleau mp270612
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8934/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #9712 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9712/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6335 percona-cluster-next for jillrouleau mp270612
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6335/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Jill, thanks for the submission! Some minor comments included inline.

review: Needs Fixing
lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-backup-action updated
75. By Jill Rouleau

correcting action to correctly set fail status, handle errors more gracefully

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10472 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10472/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9663 percona-cluster-next for jillrouleau mp270612
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9663/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6615 percona-cluster-next for jillrouleau mp270612
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6615/

lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-backup-action updated
76. By Jill Rouleau

swapping bash-bashed backup action for a python one

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #14821 percona-cluster-next for jillrouleau mp270612
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/14821/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #15879 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/15879/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8389 percona-cluster-next for jillrouleau mp270612
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8389/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #16580 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16580/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8505 percona-cluster-next for jillrouleau mp270612
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14408041/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8505/

Revision history for this message
James Page (james-page) wrote :

Again sorry for the lag - you action looks great, but your branch needs a rebase/retest before we can land it.

Please set back to 'Needs review' once that is done.

Thanks!

review: Needs Fixing
lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-backup-action updated
77. By Jill Rouleau

Resync to /next, merge backup.py into new actions.py

78. By Jill Rouleau

Resync to /next

Unmerged revisions

78. By Jill Rouleau

Resync to /next

77. By Jill Rouleau

Resync to /next, merge backup.py into new actions.py

76. By Jill Rouleau

swapping bash-bashed backup action for a python one

75. By Jill Rouleau

correcting action to correctly set fail status, handle errors more gracefully

74. By Jill Rouleau

remove extraneous symlink

73. By Jill Rouleau

add backup actions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches