Juju Charms Collection
percona-cluster package

Merge lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-n-e-m-interface into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

  1. Trusty Tahr (14.04)
  2. add-n-e-m-interface
  3. Merge into next
Proposed by Jill Rouleau
Status: Merged
Approved by: Billy Olsen
Approved revision: 74
Merged at revision: 73
Proposed branch: lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-n-e-m-interface
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 41 lines (+8/-1)
3 files modified
hooks/percona_hooks.py (+3/-0)
metadata.yaml (+3/-0)
unit_tests/test_percona_hooks.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-n-e-m-interface
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Review via email: mp+270874@code.qastaging.launchpad.net

Description of the change

Add missing n-e-m interface, config-changed so hooks will run.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #9775 percona-cluster-next for jillrouleau mp270874
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/12351174/
Build: http://10.245.162.77:8080/job/charm_lint_check/9775/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9003 percona-cluster-next for jillrouleau mp270874
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9003/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6357 percona-cluster-next for jillrouleau mp270874
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6357/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Minor nit - can you fix the lint error? Looks like too much whitespace (extra blank line) after the TO_PATCH array in unit_test/test_percona_hooks.py

review: Needs Fixing
lp://qastaging/~jillrouleau/charms/trusty/percona-cluster/add-n-e-m-interface updated
74. By Jill Rouleau

[jillr] remove extraneous newline

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9233 percona-cluster-next for jillrouleau mp270874
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9233/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10067 percona-cluster-next for jillrouleau mp270874
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10067/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6453 percona-cluster-next for jillrouleau mp270874
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6453/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Thanks Jill, this looks good to me! Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches