Code review comment for lp://qastaging/~jimbaker/pyjuju/generate-html

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Looks great, thanks Jim. Only a couple of minor comments, and it can go in IMO.

Then, for the driver! I hope we can see a waterfall working this week still!

[4]

=== added file 'pystache-LICENSE'

Please rename this to LICENSE and put it within the pystache dir itself.

[5]

+OUTPUT_STATUS_RE = re.compile(r"(?P<name>.*?)(?P<status>\.out.FAILED|\.out)")

This regex makes things more complex than it helps. E.g.:

FAILED_SUFFIX = ".out.FAILED"
OK_SUFFIX = ".out"
(...)
    if name.endswith(FAILED_SUFFIX):
        test_name = name[:-len(FAILED_SUFFIX)]

etc.

review: Approve

« Back to merge proposal