Merge lp://qastaging/~jjardon/indicator-datetime/timer-fix-837440 into lp://qastaging/indicator-datetime/0.3

Proposed by Javier Jardón
Status: Rejected
Rejected by: Ted Gould
Proposed branch: lp://qastaging/~jjardon/indicator-datetime/timer-fix-837440
Merge into: lp://qastaging/indicator-datetime/0.3
Diff against target: 1037 lines (+704/-99)
8 files modified
configure.ac (+27/-0)
src/Makefile.am (+8/-0)
src/datetime-service.c (+11/-37)
src/gnome-datetime-source.c (+283/-0)
src/gnome-datetime-source.h (+34/-0)
src/gnome-wall-clock.c (+247/-0)
src/gnome-wall-clock.h (+62/-0)
src/indicator-datetime.c (+32/-62)
To merge this branch: bzr merge lp://qastaging/~jjardon/indicator-datetime/timer-fix-837440
Reviewer Review Type Date Requested Status
Ted Gould (community) Disapprove
Review via email: mp+77625@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Indicator-datetime needs to have all contributions be copyright Canonical. I'm guessing those contributors won't sign the CLA :-)

review: Disapprove

Unmerged revisions

141. By Javier Jardón

configure.ac: Chack for timerfd support

140. By Javier Jardón

indicator-datetime: Use GnomeWallClock instead manual timers

139. By Javier Jardón

datetime-service: Use GnomeWallClock instead manual timers

138. By Javier Jardón

Copy GnomeWallClock to our tree

So we do not have to depend on unstable API

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches