The Me Menu

Merge lp://qastaging/~jjardon/indicator-me/fix-autotools into lp://qastaging/indicator-me

  1. fix-autotools
  2. Merge into trunk
Proposed by Javier Jardón
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://qastaging/~jjardon/indicator-me/fix-autotools
Merge into: lp://qastaging/indicator-me
Diff against target: 109 lines (+33/-28)
3 files modified
Makefile.am (+1/-0)
configure.ac (+31/-28)
src/Makefile.am (+1/-0)
To merge this branch: bzr merge lp://qastaging/~jjardon/indicator-me/fix-autotools
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing
Review via email: mp+65018@code.qastaging.launchpad.net

Description of the change

Update autotools config

Replace deprecated macros
Use new libtool syntax
Use upstream gettext

To post a comment you must log in.
lp://qastaging/~jjardon/indicator-me/fix-autotools updated
150. By Javier Jardón

Fix GNOMELOCALEDIR definition

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Javier, using both gettext and intltool macros is buggy though, see http://git.gnome.org/browse/vinagre/commit/?h=gnome-3-0&id=c6c5015dbd92e81856577a47d922d31ac85c7031 or https://bugs.launchpad.net/intltool/+bug/784191

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

setting as rejected, that's an old merge request on an indicator that got deprecated since

Unmerged revisions

150. By Javier Jardón

Fix GNOMELOCALEDIR definition

149. By Javier Jardón

Use upstream gettext instead the glib one

148. By Javier Jardón

Update autotools configuration

Replace deprecated macros
Use new libtool syntax

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches