Ubuntu Manual Tests

Merge lp://qastaging/~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised into lp://qastaging/ubuntu-manual-tests

  1. Xfce4Terminal-revised
  2. Merge into trunk
Proposed by Jack Fromm
Status: Merged
Merged at revision: 206
Proposed branch: lp://qastaging/~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised
Merge into: lp://qastaging/ubuntu-manual-tests
Diff against target: 166 lines (+35/-32)
2 files modified
testcases/packages/1557_Mousepad (+27/-24)
testcases/packages/1558_Xfce4 Terminal (+8/-8)
To merge this branch: bzr merge lp://qastaging/~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised
Reviewer Review Type Date Requested Status
Elfy (community) Approve
Jackson Doak (community) Approve
Review via email: mp+178856@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-08-05.

Description of the change

Change "open" instructions in Mousepad test to make them flavor-agnostic.

To post a comment you must log in.
Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

Can you make the test flavour agnostic? So the test would work on any distro.

review: Needs Fixing
Revision history for this message
Jack Fromm (jjfrv8) wrote : Posted in a previous version of this proposal

This is not a new test. I'm just modifying the one that's already on the qatracker. Elfy requested that the first one to run it check it for technical accuracy.

Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

I know, i'm just saying that's another thing that needs fixing

On Tue, Aug 6, 2013 at 10:10 AM, Jack Fromm <email address hidden> wrote:
> This is not a new test. I'm just modifying the one that's already on the qatracker. Elfy requested that the first one to run it check it for technical accuracy.
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

Revision history for this message
Elfy (elfy) wrote : Posted in a previous version of this proposal

Not so it's strictly necessary given that these tests are for people testing flavours and their default apps, or should a testcase for unity be written so it's flavour agnostic

Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

AFAIK, unless something has to not be flavour agnostic, it should be.

On Tue, Aug 6, 2013 at 4:16 PM, Elfy <email address hidden> wrote:
> Not so it's strictly necessary given that these tests are for people testing flavours and their default apps, or should a testcase for unity be written so it's flavour agnostic
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

Revision history for this message
Elfy (elfy) wrote : Posted in a previous version of this proposal

To be fair, it is if I remember correctly why I'd written

 <dt>Open Mousepad from menu</dt>

rather than

<dt>Open Mousepad from Menu -> Accessories</dt>

I think that all the tests I've written that aren't XFCE follow that generic convention.

Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

Yeah, the first option i fine, although i prefer (just an opinion)
<dt>Open Mousepad</dt>

On Tue, Aug 6, 2013 at 4:38 PM, Elfy <email address hidden> wrote:
> To be fair, it is if I remember correctly why I'd written
>
> <dt>Open Mousepad from menu</dt>
>
> rather than
>
> <dt>Open Mousepad from Menu -> Accessories</dt>
>
> I think that all the tests I've written that aren't XFCE follow that generic convention.
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

Revision history for this message
Jackson Doak (noskcaj) wrote :

Looks good. I'll wait for elfy to check it too though.

review: Approve
Revision history for this message
Elfy (elfy) wrote :

ok with me - thanks both

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches