bash-completion

Merge lp://qastaging/~jjo/bash-completion/quote_readline_by_ref_fixes into lp://qastaging/ubuntu/trusty/bash-completion

  1. quote_readline_by_ref_fixes
  2. Merge into trusty
Proposed by JuanJo Ciarlante
Status: Merged
Merge reported by: Luke Yelavich
Merged at revision: not available
Proposed branch: lp://qastaging/~jjo/bash-completion/quote_readline_by_ref_fixes
Merge into: lp://qastaging/ubuntu/trusty/bash-completion
Diff against target: 80 lines (+42/-1)
4 files modified
.pc/applied-patches (+1/-0)
bash_completion (+11/-1)
debian/patches/quote_readline_by_ref_fixes.patch (+29/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~jjo/bash-completion/quote_readline_by_ref_fixes
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Fixing
Review via email: mp+210930@code.qastaging.launchpad.net

Commit message

[jjo, r=] fix _quote_readline_by_ref to:
- avoid escaping 1st '~' (lp: #1288314)
- avoid quoting if empty, else expansion without args only shows dirs (lp: #1288031)
- replace double escaping to single (eg for completing file/paths with spaces)

To post a comment you must log in.
Revision history for this message
Luke Yelavich (themuso) wrote :

You forgot to include your patch file in your commit. I see quote_readline_by_ref_fixes.patch in debian/patches/series, but cannot find the file in the tree.

Please add the file.

Thanks for your work.

review: Needs Fixing
lp://qastaging/~jjo/bash-completion/quote_readline_by_ref_fixes updated
47. By JuanJo Ciarlante

actually add debian/patches/quote_readline_by_ref_fixes.patch

Revision history for this message
JuanJo Ciarlante (jjo) wrote :

> You forgot to include your patch file in your commit. I see
> quote_readline_by_ref_fixes.patch in debian/patches/series, but cannot find
> the file in the tree.
>
> Please add the file.
>
> Thanks for your work.

dOH! - added, thanks for the prompt review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches