Merge lp://qastaging/~jjo/charms/trusty/swift-storage/fix-upstart-nrpe-checks into lp://qastaging/~openstack-charmers-archive/charms/trusty/swift-storage/next

Proposed by JuanJo Ciarlante
Status: Merged
Merged at revision: 66
Proposed branch: lp://qastaging/~jjo/charms/trusty/swift-storage/fix-upstart-nrpe-checks
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/swift-storage/next
Diff against target: 36 lines (+13/-13)
1 file modified
hooks/swift_storage_utils.py (+13/-13)
To merge this branch: bzr merge lp://qastaging/~jjo/charms/trusty/swift-storage/fix-upstart-nrpe-checks
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Mick Gregg (community) Approve
Review via email: mp+263597@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5711 swift-storage-next for jjo mp263597
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5711/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #5343 swift-storage-next for jjo mp263597
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5343/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4903 swift-storage-next for jjo mp263597
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4903/

Revision history for this message
Mick Gregg (macgreagoir) wrote :

Confirmed service names and use in update_nrpe_config(). LGTM

review: Approve
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches