Merge lp://qastaging/~jmiguelbenitez/pantheon-photos/fix-1368626 into lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Proposed by
José M. Benítez
| Status: | Merged |
|---|---|
| Approved by: | Corentin Noël |
| Approved revision: | 2870 |
| Merged at revision: | 2872 |
| Proposed branch: | lp://qastaging/~jmiguelbenitez/pantheon-photos/fix-1368626 |
| Merge into: | lp://qastaging/~pantheon-photos/pantheon-photos/trunk |
| Diff against target: |
50 lines (+5/-20) 2 files modified
src/AppWindow.vala (+4/-11) src/util/system.vala (+1/-9) |
| To merge this branch: | bzr merge lp://qastaging/~jmiguelbenitez/pantheon-photos/fix-1368626 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Corentin Noël | Approve | ||
|
Review via email:
|
|||
Commit message
Added launch context when launching file manager to highlight the selected file
Description of the change
Item is highlighted in file manager when "Show in File Manager" option is used from the context menu.
Also, Nautilus was explicitly looked up. That has been removed to use the default file manager instead.
Please note that the fix does not work when an item is shown in the same directory than a previously open file manager instance is currently displaying. But this seems to be a Files thing (this behavior can be easily reproduced launching instances from the command line).
I guess I should file a bug against Files to see what people there say about it, but, as long as Photos is concerned, this fix should be as good as it gets ;)
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Really nice fix.