Merge lp://qastaging/~jmiguelbenitez/pantheon-photos/fix-1478642 into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

Proposed by José M. Benítez
Status: Rejected
Rejected by: Zisu Andrei
Proposed branch: lp://qastaging/~jmiguelbenitez/pantheon-photos/fix-1478642
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 22 lines (+2/-3)
1 file modified
src/Photo.vala (+2/-3)
To merge this branch: bzr merge lp://qastaging/~jmiguelbenitez/pantheon-photos/fix-1478642
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Needs Fixing
Review via email: mp+290806@code.qastaging.launchpad.net

Commit message

Keep the original Exif timestamp after a photo is transformed

Description of the change

The original Exif timestamp is kept after a photo is transformed (bug #1478642).

To test it:

1. Install exiv2 to check exif information

          sudo apt-get install exiv2

2. Check that a picture has a time stamp (backup before)

          exiv2 <file-name>.jpg | grep timestamp

2. Open the same picture through pantheon-files
3. Use the icon on the bottom left to rotate the image
4. Close the app, when prompted to save changes answer yes
5. Check the time stamp again using exiv2

          exiv2 <file-name>.jpg | grep timestamp

The timestamp should be just the same than before.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I can't confirm that this branch keeps the timestamp from changing

Revision history for this message
Zisu Andrei (matzipan) wrote :

Looking at the diff, it seemed like that else branch might have had a purpose there.

review: Needs Fixing

Unmerged revisions

2904. By José M. Benítez

Modified code in order to preserve Exif timestamp when transforming a photo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches