Merge lp://qastaging/~jml/libdep-service/correct-export-link into lp://qastaging/libdep-service

Proposed by Jonathan Lange
Status: Merged
Approved by: Jonathan Lange
Approved revision: 51
Merged at revision: 51
Proposed branch: lp://qastaging/~jml/libdep-service/correct-export-link
Merge into: lp://qastaging/libdep-service
Diff against target: 0 lines
To merge this branch: bzr merge lp://qastaging/~jml/libdep-service/correct-export-link
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+124654@code.qastaging.launchpad.net

Commit message

Put export at export/, fixing broken link on homepage

Description of the change

The export link on the homepage 404s. That's because it links to /export/
and the resource is at /export (no trailing slash)

Because I like trailing slashes, I've changed the URL of the resource
rather than the link.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Hi,

What do you think about using the "url" template tag in the template, which
will generate a url to match the url regex? You can still change the url, as
you have here, but it wouldn't be written in two places.

Thanks,

James

Revision history for this message
James Westby (james-w) :
review: Approve
Revision history for this message
ISD Branch Mangler (isd-branches-mangler) wrote :

The attempt to merge lp:~jml/libdep-service/correct-export-link into lp:libdep-service failed. Below is the output from the failed tests.

./bin/py django_project/manage.py test djlibdep
Creating test database for alias 'default'...
Destroying test database for alias 'default'...

Tree is up to date at revision 18 of branch bzr+ssh://bazaar.launchpad.net/+branch/ca-download-cache
............FFFF.............
======================================================================
FAIL: test_anonymous (djlibdep.tests.test_views.ExportTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmpwJJ6Bx/sourcecode/../djlibdep/tests/test_views.py", line 133, in test_anonymous
    self.assertEqual(403, response.status_code)
AssertionError: 403 != 301

======================================================================
FAIL: test_data (djlibdep.tests.test_views.ExportTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmpwJJ6Bx/sourcecode/../djlibdep/tests/test_views.py", line 153, in test_data
    output = sorted(self.do_query().splitlines())
  File "/tmp/tmpwJJ6Bx/sourcecode/../djlibdep/tests/test_views.py", line 124, in do_query
    self.assertEqual(200, result.status_code, result.content)
AssertionError: 200 != 301

======================================================================
FAIL: test_empty (djlibdep.tests.test_views.ExportTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmpwJJ6Bx/sourcecode/../djlibdep/tests/test_views.py", line 144, in test_empty
    self.assertEqual('', self.do_query())
  File "/tmp/tmpwJJ6Bx/sourcecode/../djlibdep/tests/test_views.py", line 124, in do_query
    self.assertEqual(200, result.status_code, result.content)
AssertionError: 200 != 301

======================================================================
FAIL: test_random_dude (djlibdep.tests.test_views.ExportTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmpwJJ6Bx/sourcecode/../djlibdep/tests/test_views.py", line 141, in test_random_dude
    self.assertEqual(403, response.status_code)
AssertionError: 403 != 301

----------------------------------------------------------------------
Ran 29 tests in 7.136s

FAILED (failures=4)
make: *** [test] Error 1

51. By Jonathan Lange

Update tests for new location.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches