libdep-service

Merge lp://qastaging/~jml/libdep-service/django-free-double into lp://qastaging/libdep-service

  1. django-free-double
  2. Merge into trunk
Proposed by Jonathan Lange
Status: Merged
Approved by: James Westby
Approved revision: 63
Merged at revision: 61
Proposed branch: lp://qastaging/~jml/libdep-service/django-free-double
Merge into: lp://qastaging/libdep-service
Diff against target: 111 lines (+26/-9)
3 files modified
djlibdep/stats.py (+6/-2)
djlibdep/test_double.py (+5/-1)
djlibdep/tests/test_interface.py (+15/-6)
To merge this branch: bzr merge lp://qastaging/~jml/libdep-service/django-free-double
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+129903@code.qastaging.launchpad.net

Commit message

Don't import Django in test double

Description of the change

The test double imports django settings in the stats module. This
  a) fixes that, by wrapping settings usage in ImportError expection things
  b) tests that, by removing DJANGO_SETTINGS_MODULE from the environment
     before running the test server

The reason "usage" rather than "import", is because Django is awesome.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches