Merge lp://qastaging/~jml/pkgme-devportal/apt-file-db into lp://qastaging/pkgme-devportal

Proposed by Jonathan Lange
Status: Merged
Approved by: James Westby
Approved revision: 132
Merged at revision: 122
Proposed branch: lp://qastaging/~jml/pkgme-devportal/apt-file-db
Merge into: lp://qastaging/pkgme-devportal
Diff against target: 547 lines (+267/-206)
5 files modified
devportalbinary/aptfile.py (+212/-0)
devportalbinary/database.py (+1/-157)
devportalbinary/tests/test_aptfile.py (+52/-0)
devportalbinary/tests/test_database.py (+1/-49)
setup.py (+1/-0)
To merge this branch: bzr merge lp://qastaging/~jml/pkgme-devportal/apt-file-db
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+124696@code.qastaging.launchpad.net

Commit message

Script to dump out the apt-file database as CSV

Description of the change

This script dumps out the apt-file database.

Also PEP8's some things and makes the code a little bit more understandable
to me.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Hi,

I would suggest making the script a console entry_point. Then buildout will
fill in the paths so you can just run the script. We don't need this script
in production, so we aren't forced to avoid buildout.

Thanks,

James

128. By Jonathan Lange

Make it an entry point. Thanks James.

129. By Jonathan Lange

Whitespace

130. By Jonathan Lange

Move AptFilePackageDatabase out of database.py module.

131. By Jonathan Lange

Move apt file tests to a separate module.

Revision history for this message
Jonathan Lange (jml) wrote :

Good idea. Done.

While at it, I moved the aptfilepackagedatabase code into a separate module.

jml

132. By Jonathan Lange

Remove the file in bin/ again.

Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches