Merge lp://qastaging/~jml/pkgme-devportal/download-file into lp://qastaging/pkgme-devportal
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 71 |
| Merged at revision: | 68 |
| Proposed branch: | lp://qastaging/~jml/pkgme-devportal/download-file |
| Merge into: | lp://qastaging/pkgme-devportal |
| Diff against target: |
89 lines (+41/-5) 2 files modified
devportalbinary/tests/test_utils.py (+17/-1) devportalbinary/utils.py (+24/-4) |
| To merge this branch: | bzr merge lp://qastaging/~jml/pkgme-devportal/download-file |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby | Approve | ||
|
Review via email:
|
|||
Commit message
Better errors for download_file and allow headers to be specified.
Description of the change
I was mucking around trying to download files behind an OpenID barrier. I didn't have any luck, but the changes I made are still useful.
To post a comment you must log in.
Revision history for this message
| James Westby (james-w) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
