Merge lp://qastaging/~jml/pkgme-devportal/libdep-srsly into lp://qastaging/pkgme-devportal
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 142 |
| Merged at revision: | 140 |
| Proposed branch: | lp://qastaging/~jml/pkgme-devportal/libdep-srsly |
| Merge into: | lp://qastaging/pkgme-devportal |
| Diff against target: |
29 lines (+4/-4) 2 files modified
devportalbinary/database.py (+2/-2) devportalbinary/tests/test_database.py (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~jml/pkgme-devportal/libdep-srsly |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby | Approve | ||
|
Review via email:
|
|||
Commit message
LibdepServiceClient now provides the correct API
Description of the change
OK, so after we added close(), things still don't work.
That's because LibdepServiceClient is almost entirely wrong. This branch
fixes it.
I haven't gone for full-scale interface verification tests -- maybe I should
have. Instead, I've just updated the direct unit tests to test the correct
interface.
I've also done manual testing with the guess-deps utility, changing my
local config to point to the staging libdep-service. That now works.
To post a comment you must log in.
Revision history for this message
| James Westby (james-w) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
