pkgme-devportal

Merge lp://qastaging/~jml/pkgme-devportal/more-fingerprints into lp://qastaging/pkgme-devportal

  1. more-fingerprints
  2. Merge into trunk
Proposed by Jonathan Lange
Status: Merged
Approved by: James Westby
Approved revision: 136
Merged at revision: 127
Proposed branch: lp://qastaging/~jml/pkgme-devportal/more-fingerprints
Merge into: lp://qastaging/pkgme-devportal
Diff against target: 571 lines (+311/-68)
15 files modified
devportalbinary/backends/desktop/all_info (+11/-0)
devportalbinary/backends/desktop/want (+11/-0)
devportalbinary/backends/diff/all_info (+11/-0)
devportalbinary/backends/diff/want (+11/-0)
devportalbinary/backends/exe/all_info (+11/-0)
devportalbinary/backends/exe/want (+11/-0)
devportalbinary/backends/image/all_info (+11/-0)
devportalbinary/backends/image/want (+11/-0)
devportalbinary/backends/shell/all_info (+11/-0)
devportalbinary/backends/shell/want (+11/-0)
devportalbinary/metadata.py (+41/-0)
devportalbinary/pdf.py (+5/-19)
devportalbinary/stubs.py (+80/-25)
devportalbinary/tests/test_stubs.py (+72/-5)
devportalbinary/unity_webapps.py (+3/-19)
To merge this branch: bzr merge lp://qastaging/~jml/pkgme-devportal/more-fingerprints
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+125236@code.qastaging.launchpad.net

Commit message

Even more stub backends

Description of the change

I said I wasn't going to do this, but it's pretty easy and will make writing
the weekly report less of a pain.

More backends, some refactoring. Not all of the new ones have tests, and
there are no integration tests.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Could unity-webapps perhaps also use your new want_single_file_with_metadata?

Thanks,

James

review: Approve
lp://qastaging/~jml/pkgme-devportal/more-fingerprints updated
135. By Jonathan Lange

Move to central location.

136. By Jonathan Lange

Use the thing for unity as well.

Revision history for this message
Jonathan Lange (jml) wrote :

On 19 September 2012 16:39, James Westby <email address hidden> wrote:
> Review: Approve
>
> Could unity-webapps perhaps also use your new want_single_file_with_metadata?

Good call. Have done so, making it use the extension thing. I don't
think the factoring is ideal, btw, but I think it's an improvement on
what we've got.

jml

Revision history for this message
James Westby (james-w) wrote :

Great, thanks, I'd been wanting to do something like that when writing the webapps
backend, but couldn't figure out a very nice interface, so I'm glad you did it.

Thanks,

James

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches