pkgme-devportal

Merge lp://qastaging/~jml/pkgme-devportal/talk-to-libdep into lp://qastaging/pkgme-devportal

  1. talk-to-libdep
  2. Merge into trunk
Proposed by Jonathan Lange
Status: Merged
Approved by: Jonathan Lange
Approved revision: 145
Merged at revision: 133
Proposed branch: lp://qastaging/~jml/pkgme-devportal/talk-to-libdep
Merge into: lp://qastaging/pkgme-devportal
Diff against target: 315 lines (+103/-18)
9 files modified
.bzrignore (+1/-0)
buildout.cfg (+1/-0)
devportalbinary/aptfile.py (+7/-0)
devportalbinary/binary.py (+7/-6)
devportalbinary/configuration.py (+3/-0)
devportalbinary/database.py (+33/-10)
devportalbinary/tests/test_database.py (+31/-2)
setup.py (+1/-0)
versions.cfg (+19/-0)
To merge this branch: bzr merge lp://qastaging/~jml/pkgme-devportal/talk-to-libdep
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+129205@code.qastaging.launchpad.net

Commit message

Allow libdep-service to be used

Description of the change

* Lots of dependencies added in order to accommodate the test double.

 * Ditched PackageDatabase.create in favour of a top-level function that
   does the dispatch based on a dict.

 * Handled it in config as a new db_type, with base_url being the only
   parameter.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Looks great.

Thanks,

James

review: Approve
Revision history for this message
ISD Branch Mangler (isd-branches-mangler) wrote :

The attempt to merge lp:~jml/pkgme-devportal/talk-to-libdep into lp:pkgme-devportal failed. Below is the output from the failed tests.

Tree is up to date at revision 26 of branch bzr+ssh://bazaar.launchpad.net/+branch/ca-download-cache
Downloading file:///tmp/tmp8qpWrC/download-cache/dist/distribute-0.6.29DEV.tar.gz
Extracting in /tmp/tmp0tkCr7
Now working in /tmp/tmp0tkCr7/distribute-0.6.29DEV
Building a Distribute egg in /tmp/tmp8qpWrC/eggs
/tmp/tmp8qpWrC/eggs/distribute-0.6.29DEV-py2.7.egg
warning: no files found matching '*.png' under directory 'docs'
warning: no files found matching '*.css' under directory 'docs'
warning: no files found matching '*.html' under directory 'docs'
warning: no files found matching '*.js' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
warning: no previously-included files found matching '.bzrignore'
warning: no previously-included files found matching 'aclocal.m4'
no previously-included directories found matching 'autom4te.cache'
no previously-included directories found matching 'c'
no previously-included directories found matching 'c++'
no previously-included directories found matching 'compile'
warning: no previously-included files found matching 'configure*'
warning: no previously-included files found matching 'depcomp'
warning: no previously-included files found matching 'INSTALL'
warning: no previously-included files found matching 'install-sh'
warning: no previously-included files found matching 'lib*'
warning: no previously-included files found matching 'ltmain.sh'
no previously-included directories found matching 'm4'
warning: no previously-included files found matching 'Makefile*'
warning: no previously-included files found matching 'missing'
no previously-included directories found matching 'perl'
warning: no previously-included files found matching 'py-compile'
no previously-included directories found matching 'shell'
no previously-included directories found matching 'python/iso8601'
warning: no previously-included files found matching 'stamp-h1'
zip_safe flag not set; analyzing archive contents...
subunit.__init__: module references __file__
no previously-included directories found matching '_build'
zip_safe flag not set; analyzing archive contents...
pkgme.tests.test_vala_backend: module references __file__
pkgme.tests.test_python_backend: module references __file__
Couldn't find index page for 'libdep-service-python' (maybe misspelled?)
While:
  Installing scripts.
  Getting distribution for 'libdep-service-python[testing]==0.0.2'.
Error: Couldn't find a distribution for 'libdep-service-python[testing]==0.0.2'.
make: *** [bin/py] Error 1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches