Merge lp://qastaging/~jml/pkgme-devportal/use-treeshape into lp://qastaging/pkgme-devportal
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 87 |
| Merged at revision: | 76 |
| Proposed branch: | lp://qastaging/~jml/pkgme-devportal/use-treeshape |
| Merge into: | lp://qastaging/pkgme-devportal |
| Diff against target: |
729 lines (+166/-162) 8 files modified
buildout.cfg (+1/-0) devportalbinary/acceptance/tests/__init__.py (+27/-21) devportalbinary/testing.py (+12/-10) devportalbinary/tests/test_binary.py (+51/-47) devportalbinary/tests/test_metadata.py (+34/-34) devportalbinary/tests/test_pdf.py (+25/-36) devportalbinary/tests/test_utils.py (+14/-13) versions.cfg (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~jml/pkgme-devportal/use-treeshape |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby | Approve | ||
|
Review via email:
|
|||
Commit message
Use treeshape for more declarative tests.
Description of the change
This isn't exactly critical work, but I wanted to anchor the treeshape stuff I've
been doing into something a bit more real.
Changes tests to use treeshape rather than TempdirFixture. Mostly means being
declarative rather than imperative.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, thanks.
James