Merge lp://qastaging/~jml/pkgme-service/forward-maintainer into lp://qastaging/pkgme-service
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 115 |
| Merged at revision: | 113 |
| Proposed branch: | lp://qastaging/~jml/pkgme-service/forward-maintainer |
| Merge into: | lp://qastaging/pkgme-service |
| Diff against target: |
92 lines (+7/-37) 3 files modified
django_project/schema.py (+2/-0) src/djpkgme/tasks.py (+0/-3) src/djpkgme/tests/test_tasks.py (+5/-34) |
| To merge this branch: | bzr merge lp://qastaging/~jml/pkgme-service/forward-maintainer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Don't override the maintainer, instead trust what the client sends to be useful.
Description of the change
Currently pkgme-service always sets the maintainer to something in a config file (pkgme-service bot). We now use the maintainer as a place to refer people to for copyright questions, and the pkgme-service bot will never be able to answer questions about copyright.
So, what this patch does is strip that logic entirely, always trusting the client to send a useful maintainer through. If they don't then we'll get the maintainer from environment variables that the user runs as.
Perhaps we want to have two "who?" attributes, one for maintainer & one for submitter, or something.
jml
To post a comment you must log in.
Revision history for this message
| James Westby (james-w) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
