Merge lp://qastaging/~jml/pkgme-service/more-info-to-myapps into lp://qastaging/pkgme-service

Proposed by Jonathan Lange
Status: Merged
Approved by: James Westby
Approved revision: 122
Merged at revision: 119
Proposed branch: lp://qastaging/~jml/pkgme-service/more-info-to-myapps
Merge into: lp://qastaging/pkgme-service
Diff against target: 609 lines (+239/-251)
4 files modified
src/djpkgme/client.py (+102/-0)
src/djpkgme/tasks.py (+17/-103)
src/djpkgme/tests/test_client.py (+112/-0)
src/djpkgme/tests/test_tasks.py (+8/-148)
To merge this branch: bzr merge lp://qastaging/~jml/pkgme-service/more-info-to-myapps
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+124433@code.qastaging.launchpad.net

Commit message

Use the new pkgme API

Description of the change

This was going to get more info to myapps, as the branch name hints.

Annoyingly, the current pkgme API isn't right yet. It would require running
all_info a couple more times, which is prohibitively expensive.

Instead, I switched to using the new pkgme.api, and cleaned out some legacy
code.

Also, I moved the code responsible for talking to myapps (or indeed, any
client) to a module named client.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Negative LoC, nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches