Merge lp://qastaging/~jml/pkgme-service/move-utils-from-tasks into lp://qastaging/pkgme-service
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 129 |
| Merged at revision: | 120 |
| Proposed branch: | lp://qastaging/~jml/pkgme-service/move-utils-from-tasks |
| Merge into: | lp://qastaging/pkgme-service |
| Diff against target: |
953 lines (+430/-372) 5 files modified
src/djpkgme/osutils.py (+120/-0) src/djpkgme/tasks.py (+54/-150) src/djpkgme/tests/__init__.py (+1/-0) src/djpkgme/tests/test_osutils.py (+150/-0) src/djpkgme/tests/test_tasks.py (+105/-222) |
| To merge this branch: | bzr merge lp://qastaging/~jml/pkgme-service/move-utils-from-tasks |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Move utilities out of tasks.py
Description of the change
I was going to add lzma support, but then realized that tasks.py is still
a huge mess.
This branch makes it slightly less messy by moving the tarball/zipfile stuff
somewhere else (osutils.py), and moving some of the stateless helper methods
to be functions.
To post a comment you must log in.
Revision history for this message
| James Westby (james-w) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
