Merge lp://qastaging/~jml/txpkgme/csv-summary into lp://qastaging/txpkgme

Proposed by Jonathan Lange
Status: Merged
Approved by: James Westby
Approved revision: 65
Merged at revision: 45
Proposed branch: lp://qastaging/~jml/txpkgme/csv-summary
Merge into: lp://qastaging/txpkgme
Diff against target: 417 lines (+241/-34)
3 files modified
txpkgme/reports.py (+144/-25)
txpkgme/scoreboard.py (+1/-7)
txpkgme/tests/test_reports.py (+96/-2)
To merge this branch: bzr merge lp://qastaging/~jml/txpkgme/csv-summary
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+126023@code.qastaging.launchpad.net

Commit message

CSV output from subunit output

Description of the change

I started writing an email about automatic packaging success.

This train of thought roughly followed:

-- You know what would make this better? A pretty picture.

-- How can I make a pretty picture? ggplot2 in R was pretty cool last time
   I used it.

-- Oh, but doing anything in R is pretty tough unless the data is already
   there in tabulated format like CSV

-- I guess it wouldn't be too hard to get CSV output

-- Huh, this subunit-to-json thing should just be a generic "turn into a
   different format" script

-- And we can _almost_ but not quite guess the backend, let's do that.

-- Oh, huh, and median sucks. Might as well fix while I'm here.

-- I have something shelved? What gi... oh, I thought I landed this.
   Might as well chuck it in too.

Thanks,
jml

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Hi,

Looks good.

It looks like if the error text has a comma in it it would change the csv as they
aren't escaped?

I might have done a len(results) check before printing getting the median times, but
this way is fine too.

Thanks,

James

review: Approve
64. By Jonathan Lange

Handle comma in cells

65. By Jonathan Lange

If there are no results, just say so.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches